lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC
On Thu, Nov 05, 2020 at 01:49:38PM +0800, Rahul Tanwar wrote:
> Patch 1 adds dt binding document in YAML format.
> Patch 2 add PWM fan controller driver for LGM SoC.
>
> v15:
> - Rebase to latest linux 5.10-rc2
>
> v14:
> - Address below review concerns from Uwe Kleine-K?nig.
> * Add limitations info about fixed 2-wire mode support.
> * Rename clk/reset _disable function names to _release.
> * Remove clk & rst from driver data structure. Instead
> use them as arguments.
> * Add pwm_chip.base = -1.
> - Resolve missing MODULE_LICENSE warning.
>
> v13:
> - Address below review concerns (Philipp Zabel)
> * Make unnecessary 2 line comment as 1 line comment.
> * Move reset_deassert at the last after clk_enable.
> * Remove unnecessary return ret statement from .remove()
> - Move platform_set_drvdata() at the top of probe.

Uwe,

you had concerns about v13 of this. Can you take a look if all your
comments have been addressed?

Thanks,
Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-11-11 21:41    [W:0.047 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site