Messages in this thread | | | From | Alex Deucher <> | Date | Tue, 10 Nov 2020 13:35:35 -0500 | Subject | Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition |
| |
Applied. Thanks!
Alex
On Tue, Nov 10, 2020 at 9:13 AM Harry Wentland <harry.wentland@amd.com> wrote: > > On 2020-11-10 3:03 a.m., Bernard Zhao wrote: > > In function amdgpu_dm_connector_get_modes, drm_edid_is_valid > > will check weather (!edid), no need to check again in the if > > branch. > > > > Signed-off-by: Bernard Zhao <bernard@vivo.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index e93e18c06c0e..0a283d07fe10 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) > > > > encoder = amdgpu_dm_connector_to_encoder(connector); > > > > - if (!edid || !drm_edid_is_valid(edid)) { > > + if (!drm_edid_is_valid(edid)) { > > amdgpu_dm_connector->num_modes = > > drm_add_modes_noedid(connector, 640, 480); > > } else { > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
| |