lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units
    From
    Date
    On 11/9/20 8:50 PM, Mathieu Poirier wrote:
    > On Wed, Oct 28, 2020 at 10:09:45PM +0000, Suzuki K Poulose wrote:
    >> Document the bindings for ETMs with system register accesses.
    >>
    >> Cc: devicetree@vger.kernel.org
    >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    >> Cc: Mike Leach <mike.leach@linaro.org>
    >> Cc: Rob Herring <robh@kernel.org>
    >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    >> ---
    >> Documentation/devicetree/bindings/arm/coresight.txt | 5 ++++-
    >> 1 file changed, 4 insertions(+), 1 deletion(-)
    >>
    >> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
    >> index d711676b4a51..bff96a550102 100644
    >> --- a/Documentation/devicetree/bindings/arm/coresight.txt
    >> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
    >> @@ -34,9 +34,12 @@ its hardware characteristcs.
    >> Program Flow Trace Macrocell:
    >> "arm,coresight-etm3x", "arm,primecell";
    >>
    >> - - Embedded Trace Macrocell (version 4.x):
    >> + - Embedded Trace Macrocell (version 4.x), with memory mapped access.
    >> "arm,coresight-etm4x", "arm,primecell";
    >>
    >> + - Embedded Trace Macrocell with system register access only.
    >> + "arm,coresight-etm-sysreg";
    >
    > Please make this "arm,coresight-etm4x-sysreg". Up to now all reference of
    > "etm" without a version related to ETMv3/PTM1.1. If we start mixing things it
    > will be come insanely confusing.

    Agreed. will rename it.

    Suzuki

    \
     
     \ /
      Last update: 2020-11-10 11:52    [W:4.439 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site