Messages in this thread | | | Date | Tue, 10 Nov 2020 08:38:24 +0000 | From | Paul Cercueil <> | Subject | Re: [PATCH] mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc_get() |
| |
Hi,
Le sam. 31 oct. 2020 à 18:54, Yu Kuai <yukuai3@huawei.com> a écrit : > of_find_device_by_node() already takes a reference to the device, and > ingenic_ecc_release() will drop the reference. So, the get_device() in > ingenic_ecc_get() is redundand. > > Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and > SoC specific code") > Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Thanks, -Paul
> --- > drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > index 8e22cd6ec71f..efe0ffe4f1ab 100644 > --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > @@ -71,8 +71,6 @@ static struct ingenic_ecc *ingenic_ecc_get(struct > device_node *np) > if (!pdev || !platform_get_drvdata(pdev)) > return ERR_PTR(-EPROBE_DEFER); > > - get_device(&pdev->dev); > - > ecc = platform_get_drvdata(pdev); > clk_prepare_enable(ecc->clk); > > -- > 2.25.4 >
| |