lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 net-next 09/11] net: hns3: add support for EQ/CQ mode configuration
From
Date


On 2020/11/11 9:25, Jakub Kicinski wrote:
> On Mon, 9 Nov 2020 11:22:37 +0800 Huazhong Tan wrote:
>> For device whose version is above V3(include V3), the GL can
>> select EQ or CQ mode, so adds support for it.
>>
>> In CQ mode, the coalesced timer will restart upon new completion,
>> while in EQ mode, the timer will not restart.
>>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>
> Let's see if I understand - in CQ mode the timer is restarted very time
> new frame gets received/transmitted? IOW for a continuous stream of
> frames it will only generate an interrupt once it reaches max_frames?
>

Hi, Jakub.

This EQ/CQ is related to the GL(gap limiting, interrupt coalesce based
on the gap time).

More exactly, the coalesced timer will restart when the first new
completion occurs. Will fix the commit log.

> I think that if you need such a configuration knob we should add this as
> an option to the official ethtool -c/-C interface, now that we have the
> ability to extend the netlink API.
>

It seems need more jobs to be did later.

Thanks.

> .
>

\
 
 \ /
  Last update: 2020-11-11 04:05    [W:0.186 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site