lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 07/26] memory: tegra30-emc: Make driver modular
    Date
    Add modularization support to the Tegra30 EMC driver, which now can be
    compiled as a loadable kernel module.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    drivers/memory/tegra/Kconfig | 2 +-
    drivers/memory/tegra/mc.c | 3 +++
    drivers/memory/tegra/tegra30-emc.c | 17 ++++++++++++-----
    3 files changed, 16 insertions(+), 6 deletions(-)

    diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
    index 8cc1ec5be443..2a4a16bcf91c 100644
    --- a/drivers/memory/tegra/Kconfig
    +++ b/drivers/memory/tegra/Kconfig
    @@ -21,7 +21,7 @@ config TEGRA20_EMC
    external memory.

    config TEGRA30_EMC
    - bool "NVIDIA Tegra30 External Memory Controller driver"
    + tristate "NVIDIA Tegra30 External Memory Controller driver"
    default y
    depends on TEGRA_MC && ARCH_TEGRA_3x_SOC
    help
    diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
    index a7e6a8e4c95a..44064de962c2 100644
    --- a/drivers/memory/tegra/mc.c
    +++ b/drivers/memory/tegra/mc.c
    @@ -6,6 +6,7 @@
    #include <linux/clk.h>
    #include <linux/delay.h>
    #include <linux/dma-mapping.h>
    +#include <linux/export.h>
    #include <linux/interrupt.h>
    #include <linux/kernel.h>
    #include <linux/module.h>
    @@ -346,6 +347,7 @@ int tegra_mc_write_emem_configuration(struct tegra_mc *mc, unsigned long rate)

    return 0;
    }
    +EXPORT_SYMBOL_GPL(tegra_mc_write_emem_configuration);

    unsigned int tegra_mc_get_emem_device_count(struct tegra_mc *mc)
    {
    @@ -357,6 +359,7 @@ unsigned int tegra_mc_get_emem_device_count(struct tegra_mc *mc)

    return dram_count;
    }
    +EXPORT_SYMBOL_GPL(tegra_mc_get_emem_device_count);

    static int load_one_timing(struct tegra_mc *mc,
    struct tegra_mc_timing *timing,
    diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
    index 1be28e28ec34..d0926088360a 100644
    --- a/drivers/memory/tegra/tegra30-emc.c
    +++ b/drivers/memory/tegra/tegra30-emc.c
    @@ -1330,6 +1330,13 @@ static int tegra_emc_probe(struct platform_device *pdev)
    platform_set_drvdata(pdev, emc);
    tegra_emc_debugfs_init(emc);

    + /*
    + * Don't allow the kernel module to be unloaded. Unloading adds some
    + * extra complexity which doesn't really worth the effort in a case of
    + * this driver.
    + */
    + try_module_get(THIS_MODULE);
    +
    return 0;

    unset_cb:
    @@ -1380,6 +1387,7 @@ static const struct of_device_id tegra_emc_of_match[] = {
    { .compatible = "nvidia,tegra30-emc", },
    {},
    };
    +MODULE_DEVICE_TABLE(of, tegra_emc_of_match);

    static struct platform_driver tegra_emc_driver = {
    .probe = tegra_emc_probe,
    @@ -1390,9 +1398,8 @@ static struct platform_driver tegra_emc_driver = {
    .suppress_bind_attrs = true,
    },
    };
    +module_platform_driver(tegra_emc_driver);

    -static int __init tegra_emc_init(void)
    -{
    - return platform_driver_register(&tegra_emc_driver);
    -}
    -subsys_initcall(tegra_emc_init);
    +MODULE_AUTHOR("Dmitry Osipenko <digetx@gmail.com>");
    +MODULE_DESCRIPTION("NVIDIA Tegra30 EMC driver");
    +MODULE_LICENSE("GPL v2");
    --
    2.29.2
    \
     
     \ /
      Last update: 2020-11-11 02:18    [W:3.670 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site