Messages in this thread | | | Date | Tue, 10 Nov 2020 17:12:17 +0900 | From | Takashi Sakamoto <> | Subject | Re: [PATCH] ALSA: firewire: fix comparison to bool warning |
| |
On Tue, Nov 10, 2020 at 09:06:29AM +0100, Takashi Iwai wrote: > On Sat, 07 Nov 2020 17:13:31 +0100, > xiakaixu1987@gmail.com wrote: > > > > From: Kaixu Xia <kaixuxia@tencent.com> > > > > Fix the following coccicheck warning: > > > > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool > > > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
The message seems not to reach my mailbox. Anyway:
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Thanks, applied. > > > Takashi > > > --- > > sound/firewire/amdtp-stream.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h > > index 2ceb57d1d58e..a3daa1f2c1c4 100644 > > --- a/sound/firewire/amdtp-stream.h > > +++ b/sound/firewire/amdtp-stream.h > > @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s, > > unsigned int timeout) > > { > > return wait_event_timeout(s->callback_wait, > > - s->callbacked == true, > > + s->callbacked, > > msecs_to_jiffies(timeout)) > 0; > > } > > > > -- > > 2.20.0
Regards
Takashi Sakamoto
| |