lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param
    On Tue, Nov 10, 2020 at 2:31 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Function parameter or member 'p' not described in 'evergreen_cs_packet_parse_vline'
    > drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Excess function parameter 'parser' description in 'evergreen_cs_packet_parse_vline'
    > drivers/gpu/drm/radeon/evergreen_cs.c:1095: warning: Function parameter or member 'p' not described in 'evergreen_cs_handle_reg'
    > drivers/gpu/drm/radeon/evergreen_cs.c:1095: warning: Excess function parameter 'parser' description in 'evergreen_cs_handle_reg'
    > drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Function parameter or member 'p' not described in 'evergreen_is_safe_reg'
    > drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Excess function parameter 'parser' description in 'evergreen_is_safe_reg'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/radeon/evergreen_cs.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
    > index c410cad28f19f..53b75cf201958 100644
    > --- a/drivers/gpu/drm/radeon/evergreen_cs.c
    > +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
    > @@ -1015,7 +1015,7 @@ static int evergreen_cs_track_check(struct radeon_cs_parser *p)
    >
    > /**
    > * evergreen_cs_packet_parse_vline() - parse userspace VLINE packet
    > - * @parser: parser structure holding parsing context.
    > + * @p: parser structure holding parsing context.
    > *
    > * This is an Evergreen(+)-specific function for parsing VLINE packets.
    > * Real work is done by r600_cs_common_vline_parse function.
    > @@ -1087,7 +1087,7 @@ static int evergreen_cs_parse_packet0(struct radeon_cs_parser *p,
    >
    > /**
    > * evergreen_cs_handle_reg() - process registers that need special handling.
    > - * @parser: parser structure holding parsing context
    > + * @p: parser structure holding parsing context
    > * @reg: register we are testing
    > * @idx: index into the cs buffer
    > */
    > @@ -1747,7 +1747,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
    >
    > /**
    > * evergreen_is_safe_reg() - check if register is authorized or not
    > - * @parser: parser structure holding parsing context
    > + * @p: parser structure holding parsing context
    > * @reg: register we are testing
    > *
    > * This function will test against reg_safe_bm and return true
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-11 00:58    [W:5.638 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site