Messages in this thread | | | From | Richard Weinberger <> | Date | Tue, 10 Nov 2020 22:34:17 +0100 | Subject | Re: [PATCH 1/2] jffs2: fix ignoring mounting options problem during remounting |
| |
On Wed, Oct 14, 2020 at 9:01 AM Zhe Li <lizhe67@huawei.com> wrote: > > From: lizhe <lizhe67@huawei.com> > > The jffs2 mount options will be ignored when remounting jffs2. > It can be easily reproduced with the steps listed below. > 1. mount -t jffs2 -o compr=none /dev/mtdblockx /mnt > 2. mount -o remount compr=zlib /mnt > > Since ec10a24f10c8, the option parsing happens before fill_super and > then pass fc, which contains the options parsing results, to function > jffs2_reconfigure during remounting. But function jffs2_reconfigure do > not update c->mount_opts. > > This patch add a function jffs2_update_mount_opts to fix this problem.
Oh, a regression. Thanks for fixing.
> By the way, I notice that tmpfs use the same way to update remounting > options. If it is necessary to unify them?
If possible, sure. Maybe you can find a way to put the logic into fs/libfs.c
-- Thanks, //richard
| |