Messages in this thread | | | Subject | Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error | From | Dmitry Osipenko <> | Date | Tue, 10 Nov 2020 10:44:14 +0300 |
| |
09.11.2020 10:25, Ard Biesheuvel пишет: ... >>> So the options are >>> >>> a) merge my patch that adds 2 bytes of opcode to the Thumb2 build >>> b) merge Dmitry's patch that adds an unconditional literal load to all builds >>> c) remove kernel mode handling from vfp_support_entry() [my other patch] >>> d) move sections around so that vfp_kmode_exception is guaranteed to >>> be in range. >>> e) do nothing ... >> The performance argument is questionable to me, to be honest. In >> practice the performance difference should be absolutely negligible for >> either of the proposed options, it should stay in a noise even if >> somebody thoroughly counting cycles, IMO. >> >> I'm still thinking that the best option will be to apply a). >> > > Can we take that as an acked-by?
Are you asking me for the ack? I think this is a more appropriate question to Russel. I'm not arm/ maintainer, but could give r-b and t-b.
If you're going to follow approach that I'm suggesting with a) + d), then could you please resend the two patches in a single series? The first one-line patch-fix should contain the fixes tag.
| |