lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 21/30] drm/radeon/atom: Move 'radeon_atom_hw_i2c_*()'s prototypes into shared header
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/gpu/drm/radeon/atombios_i2c.c:100:5: warning: no previous prototype for ‘radeon_atom_hw_i2c_xfer’ [-Wmissing-prototypes]
    100 | int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap,
    | ^~~~~~~~~~~~~~~~~~~~~~~
    drivers/gpu/drm/radeon/atombios_i2c.c:150:5: warning: no previous prototype for ‘radeon_atom_hw_i2c_func’ [-Wmissing-prototypes]
    150 | u32 radeon_atom_hw_i2c_func(struct i2c_adapter *adap)
    | ^~~~~~~~~~~~~~~~~~~~~~~

    Cc: Alex Deucher <alexander.deucher@amd.com>
    Cc: "Christian König" <christian.koenig@amd.com>
    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: amd-gfx@lists.freedesktop.org
    Cc: dri-devel@lists.freedesktop.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/gpu/drm/radeon/atom.h | 6 ++++++
    drivers/gpu/drm/radeon/radeon_i2c.c | 4 ----
    2 files changed, 6 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/atom.h b/drivers/gpu/drm/radeon/atom.h
    index cb93b83114dbe..efc05e33b220c 100644
    --- a/drivers/gpu/drm/radeon/atom.h
    +++ b/drivers/gpu/drm/radeon/atom.h
    @@ -160,6 +160,12 @@ struct radeon_device;
    bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index,
    struct drm_display_mode *mode);

    +struct i2c_msg;
    +struct i2c_adapter;
    +int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap,
    + struct i2c_msg *msgs, int num);
    +u32 radeon_atom_hw_i2c_func(struct i2c_adapter *adap);
    +
    #include "atom-types.h"
    #include "atombios.h"
    #include "ObjectID.h"
    diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
    index aa61b3cb4049c..e543d993f73ee 100644
    --- a/drivers/gpu/drm/radeon/radeon_i2c.c
    +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
    @@ -34,10 +34,6 @@
    #include "radeon.h"
    #include "atom.h"

    -extern int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap,
    - struct i2c_msg *msgs, int num);
    -extern u32 radeon_atom_hw_i2c_func(struct i2c_adapter *adap);
    -
    bool radeon_ddc_probe(struct radeon_connector *radeon_connector, bool use_aux)
    {
    u8 out = 0x0;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-10 20:33    [W:4.397 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site