Messages in this thread | | | Subject | Re: [PATCH] xfrm/compat: Remove use of kmalloc_track_caller | From | Dmitry Safonov <> | Date | Sun, 1 Nov 2020 23:34:11 +0000 |
| |
On 11/1/20 10:08 PM, Alistair Delva wrote: > The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are > enabled instead of SLAB, which breaks the build on such configs when > CONFIG_XFRM_USER_COMPAT=m. > > ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined! > > Other users of this symbol are 'bool' options, but changing this to > bool would require XFRM_USER to be built in as well, which doesn't > seem worth it. Go back to kmalloc(). > > Fixes: 96392ee5a13b9 ("xfrm/compat: Translate 32-bit user_policy from sockptr") > Cc: Dmitry Safonov <0x7f454c46@gmail.com> > Cc: Maciej Żenczykowski <maze@google.com> > Cc: Steffen Klassert <steffen.klassert@secunet.com> > Signed-off-by: Alistair Delva <adelva@google.com>
Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>
Thank you!
-- Dmitry
| |