lkml.org 
[lkml]   [2020]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] mm:backing-dev: Use sysfs_emit in macro defining functions
    Date
    The cocci script used in commit bdacbb8d04f ("mm: Use sysfs_emit
    for struct kobject * uses") does not convert the name##_show macro
    because the macro uses concatenation via ##.

    Convert it by hand.

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    mm/backing-dev.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/mm/backing-dev.c b/mm/backing-dev.c
    index 408d5051d05b..e33797579338 100644
    --- a/mm/backing-dev.c
    +++ b/mm/backing-dev.c
    @@ -150,11 +150,11 @@ static ssize_t read_ahead_kb_store(struct device *dev,

    #define BDI_SHOW(name, expr) \
    static ssize_t name##_show(struct device *dev, \
    - struct device_attribute *attr, char *page) \
    + struct device_attribute *attr, char *buf) \
    { \
    struct backing_dev_info *bdi = dev_get_drvdata(dev); \
    \
    - return snprintf(page, PAGE_SIZE-1, "%lld\n", (long long)expr); \
    + return sysfs_emit(buf, "%lld\n", (long long)expr); \
    } \
    static DEVICE_ATTR_RW(name);

    @@ -200,11 +200,11 @@ BDI_SHOW(max_ratio, bdi->max_ratio)

    static ssize_t stable_pages_required_show(struct device *dev,
    struct device_attribute *attr,
    - char *page)
    + char *buf)
    {
    dev_warn_once(dev,
    "the stable_pages_required attribute has been removed. Use the stable_writes queue attribute instead.\n");
    - return snprintf(page, PAGE_SIZE-1, "%d\n", 0);
    + return sysfs_emit(buf, "%d\n", 0);
    }
    static DEVICE_ATTR_RO(stable_pages_required);

    --
    2.26.0
    \
     
     \ /
      Last update: 2020-11-01 21:13    [W:4.575 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site