Messages in this thread | | | Date | Fri, 9 Oct 2020 14:27:04 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] mm: Fix a race during split THP |
| |
On Fri, Oct 09, 2020 at 03:36:47PM +0800, Huang, Ying wrote: > + if (PageSwapCache(head)) { > + swp_entry_t entry = { .val = page_private(head) }; > + > + split_swap_cluster(entry); > + } ... > - if (PageSwapCache(head)) { > - swp_entry_t entry = { .val = page_private(head) }; > - > - ret = split_swap_cluster(entry);
Are we sure split_swap_cluster() can't fail? Or if it does fail, it's OK to continue with the split and not report the error?
| |