lkml.org 
[lkml]   [2020]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 1/2] dt-bindings: leds: Add bindings for MT6360 LED
    From
    Date
    Hi Gene,

    Thanks for the update.

    On 10/7/20 3:42 AM, Gene Chen wrote:
    > From: Gene Chen <gene_chen@richtek.com>
    >
    > Add bindings document for LED support on MT6360 PMIC
    >
    > Signed-off-by: Gene Chen <gene_chen@richtek.com>
    > ---
    > .../devicetree/bindings/leds/leds-mt6360.yaml | 95 ++++++++++++++++++++++
    > 1 file changed, 95 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
    > new file mode 100644
    > index 0000000..2fa636f
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
    > @@ -0,0 +1,95 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: LED driver for MT6360 PMIC from MediaTek Integrated.
    > +
    > +maintainers:
    > + - Gene Chen <gene_chen@richtek.com>
    > +
    > +description: |
    > + This module is part of the MT6360 MFD device.
    > + see Documentation/devicetree/bindings/mfd/mt6360.yaml
    > + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
    > + and 4-channel RGB LED support Register/Flash/Breath Mode
    > +
    > +properties:
    > + compatible:
    > + const: mediatek,mt6360-led
    > +
    > + "#address-cells":
    > + const: 1
    > +
    > + "#size-cells":
    > + const: 0
    > +
    > +patternProperties:
    > + "^led@[0-3]$":
    > + type: object
    > + $ref: common.yaml#
    > + description:
    > + Properties for a single LED.
    > +
    > + properties:
    > + reg:
    > + description: Index of the LED.
    > + enum:
    > + - 0 # LED output INDICATOR1_RGB
    > + - 1 # LED output INDICATOR2
    > + - 2 # LED output FLED1
    > + - 3 # LED output FLED2
    > +
    > +unevaluatedProperties: false
    > +
    > +required:
    > + - compatible
    > + - "#address-cells"
    > + - "#size-cells"
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/leds/common.h>
    > + led-controller {
    > + compatible = "mediatek,mt6360-led";
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > + led@0 {
    > + reg = <0>;
    > + function = LED_FUNCTION_INDICATOR;
    > + color = <LED_COLOR_ID_RGB>;
    > + led-max-microamp = <24000>;
    > + };

    This should be multi-led node. See [0] for a reference.

    > + led@1 {
    > + reg = <1>;
    > + function = LED_FUNCTION_INDICATOR;

    Maybe add LED_FUNCTION_MOONLIGHT ?

    > + color = <LED_COLOR_ID_AMBER>;
    > + default-state = "off";
    > + led-max-microamp = <150000>;
    > + };
    > + led@2 {
    > + reg = <2>;
    > + function = LED_FUNCTION_FLASH;
    > + color = <LED_COLOR_ID_WHITE>;
    > + function-enumerator = <1>;
    > + default-state = "off";
    > + led-max-microamp = <200000>;
    > + flash-max-microamp = <500000>;
    > + flash-max-timeout-us = <1024000>;
    > + };
    > + led@3 {
    > + reg = <3>;
    > + function = LED_FUNCTION_FLASH;
    > + color = <LED_COLOR_ID_WHITE>;
    > + function-enumerator = <2>;
    > + default-state = "off";
    > + led-max-microamp = <200000>;
    > + flash-max-microamp = <500000>;
    > + flash-max-timeout-us = <1024000>;
    > + };
    > + };
    > +...
    >

    [0]
    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml

    --
    Best regards,
    Jacek Anaszewski

    \
     
     \ /
      Last update: 2020-10-08 23:43    [W:4.584 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site