Messages in this thread | | | Date | Wed, 7 Oct 2020 13:36:54 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] sparc: Check VMA range in sparc_validate_prot() |
| |
> +++ b/arch/sparc/include/asm/mman.h > @@ -60,31 +60,41 @@ static inline int sparc_validate_prot(unsigned long prot, unsigned long addr, > if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_ADI)) > return 0; > if (prot & PROT_ADI) { > + struct vm_area_struct *vma, *next; > +
I'd split all the ADI logic into a separate, preferable out of line helper.
> + /* reached the end of the range without errors? */ > + if (addr+len <= vma->vm_end)
missing whitespaces around the arithmetic operator.
| |