Messages in this thread | | | Subject | Re: [PATCH] [v2] thermal: core: add upper and lower limits to power_actor_set_power | From | Lukasz Luba <> | Date | Wed, 7 Oct 2020 11:55:14 +0100 |
| |
On 10/7/20 3:43 AM, Michael Kao wrote: > The upper and lower limits of thermal throttle state in the > DT do not apply to the Intelligent Power Allocation (IPA) governor. > Add the clamping for cooling device upper and lower limits in the > power_actor_set_power() used by IPA. > > Signed-off-by: Michael Kao <michael.kao@mediatek.com> > --- > drivers/thermal/thermal_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 72bf159bcecc..a260e4a575f3 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -674,7 +674,7 @@ int power_actor_set_power(struct thermal_cooling_device *cdev, > if (ret) > return ret; > > - instance->target = state; > + instance->target = clamp_val(state, instance->lower, instance->upper); > mutex_lock(&cdev->lock); > cdev->updated = false; > mutex_unlock(&cdev->lock); >
Please check the patch with scripts/checkpatch.pl before sending. It's again base64 encoded, I was able to apply it on my end with --ignore-whitespace, but still some odd char is there.
If Daniel is OK to fix it when applying to the thermal branch, then:
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> Tested-by: Lukasz Luba <lukasz.luba@arm.com>
I would send a few patches on top of this one, to fully support the upper and lower limits in IPA.
Regards, Lukasz
| |