| Date | Wed, 7 Oct 2020 11:47:37 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 27/38] iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate() |
| |
Hi!
> From: Yu Kuai <yukuai3@huawei.com> > > [ Upstream commit 1a26044954a6d1f4d375d5e62392446af663be7a ] > > if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation.
Okay, this looks reasonable, but...
Do we miss put_device() in normal path, too? I'd expect another put_device at end of exynos_iommu_of_xlate() or perhaps in release path somewhere...
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |