Messages in this thread | | | Date | Wed, 7 Oct 2020 10:32:27 +0300 | From | Ivan Zaentsev <> | Subject | Re: [PATCH 2/2] w1: w1_therm: Add support for GXCAS GX20MH01 device. |
| |
Tuesday, October 6, 2020, 4:19:15 PM, Mauro Carvalho Chehab wrote:
>> diff --git a/Documentation/w1/slaves/w1_therm.rst b/Documentation/w1/slaves/w1_therm.rst >> index f1148181f53e..00376501a5ef 100644 >> --- a/Documentation/w1/slaves/w1_therm.rst >> +++ b/Documentation/w1/slaves/w1_therm.rst
>> >> @@ -130,4 +131,12 @@ conversion and temperature reads 85.00 (powerup value) or 127.94 (insufficient >> power), the driver returns a conversion error. Bit mask ``2`` enables poll for >> conversion completion (normal power only) by generating read cycles on the bus >> after conversion starts. In parasite power mode this feature is not available. >> -Feature bit masks may be combined (OR). >> +Feature bit masks may be combined (OR). See accompanying sysfs documentation: >> +:ref:`Documentation/w1/slaves/w1_therm.rst <w1_therm>` >> +
> As warned by Sphinx, this cross-reference is broken:
> .../Documentation/w1/slaves/w1_therm.rst:125: WARNING: > undefined label: w1_therm (if the link has no caption the label must precede a section header)
Would this be ok?
"More details in Documentation/ABI/testing/sysfs-driver-w1_therm"
> Not sure what you wanted to point here.
A link to a driver's sysfs interface, but sysfs docs are text files and seem to not be included in Sphynx Docs.
-- Best regards, Ivan mailto:ivan.zaentsev@wirenboard.ru
| |