Messages in this thread | | | Subject | Re: [PATCH] qla2xxx: Do not consume srb greedily | From | "Martin K. Petersen" <> | Date | Wed, 07 Oct 2020 22:19:39 -0400 |
| |
Daniel,
> qla2xx_process_get_sp_from_handle() will clear the slot which the > current srb is stored. So this function has a side effect. Therefore, > we can't use it in qla24xx_process_mbx_iocb_response() to check > for consistency and later again in qla24xx_mbx_iocb_entry(). > > Let's move the consistency check directly into > qla24xx_mbx_iocb_entry() and avoid the double call or any open coding > of the qla2xx_process_get_sp_from_handle() functionality.
Applied to 5.10/scsi-staging, thanks!
-- Martin K. Petersen Oracle Linux Engineering
| |