Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 6 Oct 2020 14:35:44 -0700 | Subject | Re: [PATCH] crypto: xor - Remove unused variable count in do_xor_speed |
| |
Hi,
On Tue, Oct 6, 2020 at 12:59 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns: > > crypto/xor.c:101:4: warning: variable 'count' is uninitialized when used > here [-Wuninitialized] > count++; > ^~~~~ > crypto/xor.c:86:17: note: initialize the variable 'count' to silence > this warning > int i, j, count; > ^ > = 0 > 1 warning generated. > > After the refactoring to use ktime that happened in this function, count > is only assigned, never read. Just remove the variable to get rid of the > warning. > > Fixes: c055e3eae0f1 ("crypto: xor - use ktime for template benchmarking") > Link: https://github.com/ClangBuiltLinux/linux/issues/1171 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > crypto/xor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-)
Whoops! Sorry for missing this in my review.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |