Messages in this thread | | | From | Coiby Xu <> | Date | Tue, 6 Oct 2020 12:14:53 +0800 | Subject | Re: [PATCH v2 1/3] staging: greybus: fix warnings about endianness detected by sparse |
| |
On Tue, Oct 06, 2020 at 12:47:37AM +0530, Vaibhav Agarwal wrote: >On Sat, Oct 3, 2020 at 5:01 AM Coiby Xu <coiby.xu@gmail.com> wrote: >> >> This patch fix the following warnings from sparse, >> >> $ make C=2 drivers/staging/greybus/ >> drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_module.c:222:25: expected restricted __le16 [usertype] data_cport >> drivers/staging/greybus/audio_module.c:222:25: got unsigned short [usertype] intf_cport_id >> drivers/staging/greybus/audio_topology.c:460:40: warning: restricted __le32 degrades to integer >> drivers/staging/greybus/audio_topology.c:691:41: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_topology.c:691:41: expected unsigned int access >> drivers/staging/greybus/audio_topology.c:691:41: got restricted __le32 [usertype] access >> drivers/staging/greybus/audio_topology.c:746:44: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_topology.c:746:44: expected unsigned int >> drivers/staging/greybus/audio_topology.c:746:44: got restricted __le32 >> drivers/staging/greybus/audio_topology.c:748:52: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_topology.c:748:52: expected unsigned int >> drivers/staging/greybus/audio_topology.c:748:52: got restricted __le32 >> drivers/staging/greybus/audio_topology.c:802:42: warning: restricted __le32 degrades to integer >> drivers/staging/greybus/audio_topology.c:805:50: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_topology.c:805:50: expected restricted __le32 >> drivers/staging/greybus/audio_topology.c:805:50: got unsigned int >> drivers/staging/greybus/audio_topology.c:814:50: warning: restricted __le32 degrades to integer >> drivers/staging/greybus/audio_topology.c:817:58: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_topology.c:817:58: expected restricted __le32 >> drivers/staging/greybus/audio_topology.c:817:58: got unsigned int >> drivers/staging/greybus/audio_topology.c:889:25: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_topology.c:889:25: expected unsigned int access >> drivers/staging/greybus/audio_topology.c:889:25: got restricted __le32 [usertype] access >> >> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> >> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> >> Reviewed-by: Alex Elder <elder@linaro.org> >> Signed-off-by: Coiby Xu <coiby.xu@gmail.com> >> --- >Hi Coiby, > >Thanks for sharing the patch. Sorry, I could not reply to the v1 series. >Now, I have gone through the patches. Looks good (all 3 patches). > >Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com> > >-- >Thanks,
Hi Vaibhav,
Thank you for reviewing these patches and giving the credit!
-- Best regards, Coiby
| |