lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 11/85] gpio: tc35894: fix up tc35894 interrupt configuration
    Date
    From: dillon min <dillon.minfei@gmail.com>

    commit 214b0e1ad01abf4c1f6d8d28fa096bf167e47cef upstream.

    The offset of regmap is incorrect, j * 8 is move to the
    wrong register.

    for example:

    asume i = 0, j = 1. we want to set KPY5 as interrupt
    falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd
    but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4,
    this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1.

    Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver")
    Cc: Cc: stable@vger.kernel.org
    Signed-off-by: dillon min <dillon.minfei@gmail.com>
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpio/gpio-tc3589x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpio/gpio-tc3589x.c
    +++ b/drivers/gpio/gpio-tc3589x.c
    @@ -212,7 +212,7 @@ static void tc3589x_gpio_irq_sync_unlock
    continue;

    tc3589x_gpio->oldregs[i][j] = new;
    - tc3589x_reg_write(tc3589x, regmap[i] + j * 8, new);
    + tc3589x_reg_write(tc3589x, regmap[i] + j, new);
    }
    }


    \
     
     \ /
      Last update: 2020-10-05 17:33    [W:4.973 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site