Messages in this thread | | | Date | Mon, 5 Oct 2020 18:08:35 -0700 | From | Ricardo Neri <> | Subject | Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface |
| |
On Sat, Oct 03, 2020 at 01:05:48PM +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 03, 2020 at 10:53:45AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Oct 02, 2020 at 06:17:42PM -0700, Ricardo Neri wrote: > > > +/** > > > + * arch_get_cpu_type_name() - Get the CPU type name > > > + * @cpu_type: Type of CPU micro-architecture. > > > + * > > > + * Returns a string name associated with the CPU micro-architecture type as > > > + * indicated in @cpu_type. The format shall be <vendor>_<cpu_type>. Returns > > > + * NULL if the CPU type is not known. > > > + */ > > > +const char __weak *arch_get_cpu_type_name(u32 cpu_type) > > > +{ > > > + return NULL; > > > +} > > > > Why is vendor part of this? Shouldn't it just be arch? > > > > I say this as "vendor" is kind of "interesting" when it comes to other > > arches... > > > > Speaking of other arches, we all know that other arches have this > > feature as well, have you worked with any other groups to verify that > > this interface will also work with them? > > Here's one set of patches for ARM64 for much the same type of cpu > design: > https://android-review.googlesource.com/c/kernel/common/+/1437098/3 > Yes, it's not been posted to any kernel lists, but this is public so you > need to work with the ARM developers to come up with an interface that > works for everyone please.
Thanks for the pointer, Greg! I will study this proposal and work with the ARM engineers.
BR, Ricardo
| |