Messages in this thread | | | Date | Mon, 5 Oct 2020 18:05:36 -0700 | From | Ricardo Neri <> | Subject | Re: [PATCH 4/4] x86/cpu/topology: Implement the CPU type sysfs interface |
| |
On Sat, Oct 03, 2020 at 10:55:06AM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 02, 2020 at 06:17:45PM -0700, Ricardo Neri wrote: > > Recent Intel processors combine CPUs with different types of micro- > > architecture in the same package. There may be applications interested in > > knowing the type topology of the system. For instance, it can be used to > > to determine which subsets of CPUs share a common feature. > > > > Implement cpu_type sysfs interfaces for Intel processors. > > > > For example, in a system with four Intel Atom CPUs and one Intel Core CPU, > > these entries look as below. In this example, the native model IDs for > > both types of CPUs are 0: > > > > user@host:~$: ls /sys/devices/system/cpu/types > > intel_atom_0 intel_core_0 > > > > user@host:~$ ls /sys/devices/system/cpu/types/intel_atom_0 > > cpulist cpumap > > > > user@host:~$ ls /sys/devices/system/cpu/types/intel_core_0 > > cpulist cpumap > > > > user@host:~$ cat /sys/devices/system/cpu/types/intel_atom/cpumap > > 0f > > > > user@host:~$ cat /sys/devices/system/cpu/types/intel_atom/cpulist > > 0-3 > > > > user@nost:~$ cat /sys/devices/system/cpu/types/intel_core/cpumap > > 10 > > > > user@host:~$ cat /sys/devices/system/cpu/types/intel_core/cpulist > > 4 > > You used the same changelog text here as you did in patch 1/4, why?
In both changesets, if merged, somebody could conveniently do git show on either commit quickly see the result intent of the changeset.
Would it make it better if in patch 1/4 I put an hypothetical generic example?
Something like:
user@host:~$: ls /sys/devices/system/cpu/types <arch>_<type_a> <arch><type_b>
Thanks and BR, Ricardo
| |