Messages in this thread | | | Date | Mon, 5 Oct 2020 17:54:14 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH v4 3/3] iommu/tegra-smmu: Add PCI support |
| |
On Mon, Oct 05, 2020 at 12:04:19PM +0200, Thierry Reding wrote: > > +err_bus_set: __maybe_unused; > > + bus_set_iommu(&platform_bus_type, NULL); > > +err_unregister: > > + iommu_device_unregister(&smmu->iommu); > > +err_sysfs: > > + iommu_device_sysfs_remove(&smmu->iommu); > > Can you please switch to label names that are more consistent with the > others in this driver? Notably the ones in tegra_smmu_domain_alloc(). > The idea is to describe in the name of the label what's happening at the > label. Something like this, for example: > > unset_platform_bus: > bus_set_iommu(&platform_bus_type, NULL); > unregister: > iommu_device_unregister(&smmu->iommu); > remove_sysfs: > iommu_device_sysfs_remove(&smmu->iommu);
Okay. Will update in v7.
| |