Messages in this thread | | | Subject | Re: [PATCH v2 3/3] dt-bindings: thermal: update sustainable-power with abstract scale | From | Lukasz Luba <> | Date | Mon, 5 Oct 2020 17:14:57 +0100 |
| |
Hi Rob,
On 10/5/20 2:58 PM, Rob Herring wrote: > On Fri, 02 Oct 2020 12:44:26 +0100, Lukasz Luba wrote: >> Update the documentation for the binding 'sustainable-power' and allow >> to provide values in an abstract scale. It is required when the cooling >> devices use an abstract scale for their power values. >> >> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> >> --- >> .../devicetree/bindings/thermal/thermal-zones.yaml | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> > > > My bot found errors running 'make dt_binding_check' on your patch: > > Traceback (most recent call last): > File "/usr/local/bin/dt-extract-example", line 45, in <module> > binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load > return constructor.get_single_data() > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data > node = self.composer.get_single_node() > File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node > File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event > ruamel.yaml.scanner.ScannerError: while scanning a plain scalar > in "<unicode string>", line 102, column 11 > found a tab character that violates indentation > in "<unicode string>", line 103, column 1 > make[1]: *** [Documentation/devicetree/bindings/Makefile:18: Documentation/devicetree/bindings/thermal/thermal-zones.example.dts] Error 1 > make[1]: *** Deleting file 'Documentation/devicetree/bindings/thermal/thermal-zones.example.dts' > make[1]: *** Waiting for unfinished jobs.... > ./Documentation/devicetree/bindings/thermal/thermal-zones.yaml: while scanning a plain scalar > in "<unicode string>", line 102, column 11 > found a tab character that violates indentation > in "<unicode string>", line 103, column 1 > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.yaml: ignoring, error parsing file > warning: no schema found in file: ./Documentation/devicetree/bindings/thermal/thermal-zones.yaml > make: *** [Makefile:1366: dt_binding_check] Error 2 > > > See https://patchwork.ozlabs.org/patch/1375670 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. >
My apologies, I have put tabs instead of spaces in there. I have run this command and now it passed.
I will resend the patch 3/3.
Regards, Lukasz
| |