lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v4 4/4] objtool: fix x86 orc generation on big endian cross compiles
    On Mon, Oct 05, 2020 at 09:03:28AM -0500, Josh Poimboeuf wrote:
    > On Sun, Oct 04, 2020 at 04:30:54PM +0200, Vasily Gorbik wrote:
    > > @@ -77,8 +78,9 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry,
    > > if (entry->feature) {
    > > unsigned short feature;
    > >
    > > - feature = *(unsigned short *)(sec->data->d_buf + offset +
    > > - entry->feature);
    > > + feature = bswap_if_needed(*(unsigned short *)(sec->data->d_buf +
    > > + offset +
    > > + entry->feature));
    > > arch_handle_alternative(feature, alt);
    > > }
    > > ---
    > > arch/x86/include/asm/orc_types.h | 10 +++++
    > > tools/arch/x86/include/asm/orc_types.h | 10 +++++
    > > .../arch/x86/include/arch_endianness.h | 9 +++++
    >
    > This patch is misformatted. Almost like it was concatenated with
    > itself?

    Indeed. I wonder how that could have happened. Sorry for that. I've
    resent patches with rebased patch

    "objtool: avoid ../ headers includes and name clashes"

    on top. This time I checked patches could be applied from outgoing
    mailbox before sending it.

    \
     
     \ /
      Last update: 2020-10-05 17:57    [W:2.188 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site