Messages in this thread | | | Date | Sun, 4 Oct 2020 08:58:04 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.8 28/29] spi: fsl-dspi: fix use-after-free in remove path |
| |
On Tue, Sep 29, 2020 at 08:22:16AM +0200, Sascha Hauer wrote: >Hi Sasha, > >On Mon, Sep 28, 2020 at 09:30:25PM -0400, Sasha Levin wrote: >> From: Sascha Hauer <s.hauer@pengutronix.de> >> >> [ Upstream commit 530b5affc675ade5db4a03f04ed7cd66806c8a1a ] >> >> spi_unregister_controller() not only unregisters the controller, but >> also frees the controller. This will free the driver data with it, so >> we must not access it later dspi_remove(). >> >> Solve this by allocating the driver data separately from the SPI >> controller. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >> Link: https://lore.kernel.org/r/20200923131026.20707-1-s.hauer@pengutronix.de >> Signed-off-by: Mark Brown <broonie@kernel.org> >> Signed-off-by: Sasha Levin <sashal@kernel.org> >> --- >> drivers/spi/spi-fsl-dspi.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) > >This patch causes a regression and shouldn't be applied without the fix >in https://lkml.org/lkml/2020/9/28/300.
Looks like the fix didn't make it yet, so I'll drop the patch.
-- Thanks, Sasha
| |