lkml.org 
[lkml]   [2020]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] test_power: add missing newlines when printing parameters by sysfs
Here is the updated patch using sprintf, diffing from the original patch by Xiongfeng Wang.

[PATCH] test_power: revise parameter printing to use sprintf

Signed-off-by: Harley A.W. Lorenzo <hl1998@protonmail.com>
Suggested-by: Joe Perches <joe@perches.com>
---
drivers/power/supply/test_power.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c
index 4895ee5e63a9..fbb179a1b615 100644
--- a/drivers/power/supply/test_power.c
+++ b/drivers/power/supply/test_power.c
@@ -352,8 +352,8 @@ static int param_set_ac_online(const char *key, const struct kernel_param *kp)

static int param_get_ac_online(char *buffer, const struct kernel_param *kp)
{
- strcpy(buffer, map_get_key(map_ac_online, ac_online, "unknown"));
- strcat(buffer, "\n");
+ char const *out = map_get_key(map_ac_online, ac_online, "unknown");
+ sprintf(buffer, "%s\n", out);
return strlen(buffer);
}

@@ -366,8 +366,8 @@ static int param_set_usb_online(const char *key, const struct kernel_param *kp)

static int param_get_usb_online(char *buffer, const struct kernel_param *kp)
{
- strcpy(buffer, map_get_key(map_ac_online, usb_online, "unknown"));
- strcat(buffer, "\n");
+ char const *out = map_get_key(map_ac_online, usb_online, "unknown");
+ sprintf(buffer, "%s\n", out);
return strlen(buffer);
}

@@ -381,8 +381,8 @@ static int param_set_battery_status(const char *key,

static int param_get_battery_status(char *buffer, const struct kernel_param *kp)
{
- strcpy(buffer, map_get_key(map_status, battery_status, "unknown"));
- strcat(buffer, "\n");
+ char const *out = map_get_key(map_ac_online, battery_status, "unknown");
+ sprintf(buffer, "%s\n", out);
return strlen(buffer);
}

@@ -396,8 +396,8 @@ static int param_set_battery_health(const char *key,

static int param_get_battery_health(char *buffer, const struct kernel_param *kp)
{
- strcpy(buffer, map_get_key(map_health, battery_health, "unknown"));
- strcat(buffer, "\n");
+ char const *out = map_get_key(map_ac_online, battery_health, "unknown");
+ sprintf(buffer, "%s\n", out);
return strlen(buffer);
}

@@ -412,8 +412,9 @@ static int param_set_battery_present(const char *key,
static int param_get_battery_present(char *buffer,
const struct kernel_param *kp)
{
- strcpy(buffer, map_get_key(map_present, battery_present, "unknown"));
- strcat(buffer, "\n");
+ char const *out = map_get_key(map_ac_online, battery_present,
+ "unknown");
+ sprintf(buffer, "%s\n", out);
return strlen(buffer);
}

@@ -429,9 +430,9 @@ static int param_set_battery_technology(const char *key,
static int param_get_battery_technology(char *buffer,
const struct kernel_param *kp)
{
- strcpy(buffer,
- map_get_key(map_technology, battery_technology, "unknown"));
- strcat(buffer, "\n");
+ char const *out = map_get_key(map_ac_online, battery_technology,
+ "unknown");
+ sprintf(buffer, "%s\n", out);
return strlen(buffer);
}

--
2.28.0
\
 
 \ /
  Last update: 2020-10-05 03:31    [W:0.051 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site