Messages in this thread | | | Subject | Re: [PATCH 2/2] Platform integrity information in sysfs (version 9) | From | Randy Dunlap <> | Date | Sat, 3 Oct 2020 21:01:27 -0700 |
| |
On 9/30/20 9:37 AM, Daniel Gutson wrote: > diff --git a/drivers/mtd/spi-nor/controllers/Kconfig b/drivers/mtd/spi-nor/controllers/Kconfig > index 5c0e0ec2e6d1..e7eaef506fc2 100644 > --- a/drivers/mtd/spi-nor/controllers/Kconfig > +++ b/drivers/mtd/spi-nor/controllers/Kconfig > @@ -29,6 +29,7 @@ config SPI_NXP_SPIFI > > config SPI_INTEL_SPI > tristate > + depends on PLATFORM_INTEGRITY_DATA
So SPI_INTEL_SPI_PCI selects SPI_INTEL_SPI:
config SPI_INTEL_SPI_PCI tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" depends on X86 && PCI select SPI_INTEL_SPI
without checking that PLATFORM_INTEGRITY_DATA is set/enabled.
"select" does not follow any kconfig dependency chains, so when PLATFORM_INTEGRITY_DATA is not enabled, this should be causing a kconfig warning, which is not OK.
-- ~Randy
| |