Messages in this thread | | | Date | Sat, 31 Oct 2020 11:27:46 -0400 | From | Peter Xu <> | Subject | Re: [PATCH 2/2] KVM: X86: Fix null pointer reference for KVM_GET_MSRS |
| |
On Sat, Oct 31, 2020 at 03:06:59PM +0100, Paolo Bonzini wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index ce856e0ece84..5993fbd6d2c5 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -259,8 +259,8 @@ static int kvm_msr_ignored_check(struct kvm_vcpu *vcpu, u32 msr, > > > > if (ignore_msrs) { > > if (report_ignored_msrs) > > - vcpu_unimpl(vcpu, "ignored %s: 0x%x data 0x%llx\n", > > - op, msr, data); > > + kvm_pr_unimpl("ignored %s: 0x%x data 0x%llx\n", > > + op, msr, data); > > /* Mask the error */ > > return 0; > > } else { > > > > I committed Takashi Iwai's very similar patch. Please resend 1/2 with > reviewer comments addressed, thanks!
Sorry for a late reply (to reviewers).
Oh, how did I miss the other vcpu reference... that one is definitely better. :)
Will respin shortly on the test.
Thanks,
-- Peter Xu
| |