Messages in this thread | | | Date | Sat, 31 Oct 2020 01:09:10 -0400 | From | Peilin Ye <> | Subject | Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier |
| |
Hi Lee,
On Fri, Oct 30, 2020 at 06:18:22PM +0000, Lee Jones wrote: > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > built-in fonts") introduced the following error when building > rpc_defconfig (only this build appears to be affected): > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > The .data section is discarded at link time. Reinstating > acorndata_8x8 as const ensures it is still available after linking.
Thanks a lot for fixing this up! I wasn't aware that the symbol is being referenced in arch/arm/boot/compressed/ll_char_wr.S. I'm sorry for the trouble. The patch is,
> Cc: <stable@vger.kernel.org> > Cc: Russell King <linux@armlinux.org.uk> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
Tested-by: Peilin Ye <yepeilin.cs@gmail.com>
Thank you, Peilin Ye
| |