lkml.org 
[lkml]   [2020]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/6] media: vidtv: extract the initial CRC value to into a #define
    Date
    From: Daniel W. S. Almeida <dwlsalmeida@gmail.com>

    The same constant (0xffffffff) is used in three different functions.

    Extract it into a #define to avoid repetition.

    Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
    ---
    drivers/media/test-drivers/vidtv/vidtv_psi.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/test-drivers/vidtv/vidtv_psi.c b/drivers/media/test-drivers/vidtv/vidtv_psi.c
    index 82cf67dd27c0..f2e25e68c085 100644
    --- a/drivers/media/test-drivers/vidtv/vidtv_psi.c
    +++ b/drivers/media/test-drivers/vidtv/vidtv_psi.c
    @@ -31,6 +31,7 @@

    #define CRC_SIZE_IN_BYTES 4
    #define MAX_VERSION_NUM 32
    +#define INITIAL_CRC 0xffffffff

    static const u32 CRC_LUT[256] = {
    /* from libdvbv5 */
    @@ -784,7 +785,7 @@ u32 vidtv_psi_pat_write_into(struct vidtv_psi_pat_write_args args)
    /* the number of bytes written by this function */
    u32 nbytes = 0;
    const u16 pat_pid = VIDTV_PAT_PID;
    - u32 crc = 0xffffffff;
    + u32 crc = INITIAL_CRC;

    struct vidtv_psi_table_pat_program *p = args.pat->program;

    @@ -974,7 +975,7 @@ u32 vidtv_psi_pmt_write_into(struct vidtv_psi_pmt_write_args args)
    {
    /* the number of bytes written by this function */
    u32 nbytes = 0;
    - u32 crc = 0xffffffff;
    + u32 crc = INITIAL_CRC;

    struct vidtv_psi_desc *table_descriptor = args.pmt->descriptor;
    struct vidtv_psi_table_pmt_stream *stream = args.pmt->stream;
    @@ -1124,7 +1125,7 @@ u32 vidtv_psi_sdt_write_into(struct vidtv_psi_sdt_write_args args)
    u32 nbytes = 0;
    u16 sdt_pid = VIDTV_SDT_PID; /* see ETSI EN 300 468 v1.15.1 p. 11 */

    - u32 crc = 0xffffffff;
    + u32 crc = INITIAL_CRC;

    struct vidtv_psi_table_sdt_service *service = args.sdt->service;
    struct vidtv_psi_desc *service_desc = (args.sdt->service) ?
    --
    2.29.2
    \
     
     \ /
      Last update: 2020-10-31 16:07    [W:3.171 / U:1.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site