lkml.org 
[lkml]   [2020]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 32/70] chelsio/chtls: fix deadlock issue
    Date
    From: Vinay Kumar Yadav <vinay.yadav@chelsio.com>

    [ Upstream commit 28e9dcd9172028263c8225c15c4e329e08475e89 ]

    In chtls_pass_establish() we hold child socket lock using bh_lock_sock
    and we are again trying bh_lock_sock in add_to_reap_list, causing deadlock.
    Remove bh_lock_sock in add_to_reap_list() as lock is already held.

    Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition")
    Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
    Link: https://lore.kernel.org/r/20201025193538.31112-1-vinay.yadav@chelsio.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/chelsio/chtls/chtls_cm.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/crypto/chelsio/chtls/chtls_cm.c
    +++ b/drivers/crypto/chelsio/chtls/chtls_cm.c
    @@ -1513,7 +1513,6 @@ static void add_to_reap_list(struct sock
    struct chtls_sock *csk = sk->sk_user_data;

    local_bh_disable();
    - bh_lock_sock(sk);
    release_tcp_port(sk); /* release the port immediately */

    spin_lock(&reap_list_lock);
    @@ -1522,7 +1521,6 @@ static void add_to_reap_list(struct sock
    if (!csk->passive_reap_next)
    schedule_work(&reap_task);
    spin_unlock(&reap_list_lock);
    - bh_unlock_sock(sk);
    local_bh_enable();
    }


    \
     
     \ /
      Last update: 2020-10-31 12:51    [W:2.561 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site