Messages in this thread | | | Subject | Re: [PATCH v1 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs | From | Shuah Khan <> | Date | Fri, 30 Oct 2020 11:13:47 -0600 |
| |
On 10/29/20 1:02 PM, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > ... instead of poking at the MSR. For that, move the accessor functions > to misc.c and add a sysfs-writing function too. > > There should be no functional changes resulting from this. > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Thomas Renninger <trenn@suse.com> > Cc: Shuah Khan <shuah@kernel.org> > --- > tools/power/cpupower/lib/cpupower.c | 23 +++++++++- > tools/power/cpupower/lib/cpupower_intern.h | 5 ++ > tools/power/cpupower/utils/cpupower-info.c | 2 +- > tools/power/cpupower/utils/cpupower-set.c | 2 +- > tools/power/cpupower/utils/helpers/helpers.h | 8 ++-- > tools/power/cpupower/utils/helpers/misc.c | 48 ++++++++++++++++++++ > tools/power/cpupower/utils/helpers/msr.c | 28 ------------ > 7 files changed, 81 insertions(+), 35 deletions(-) >
Thanks. Looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |