lkml.org 
[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: (3) [PATCH v2] input: add 2 kind of switch
From
Date
> On Fri, Oct 30, 2020 at 01:39:16PM +0900, HyungJae Im wrote:
> > Hello, This is Hyungjae Im from Samsung Electronics.
> > Let me answer your questions inline.
> >
> > >On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote:
> > >> From: "hj2.im" <hj2.im@samsung.com>
> > >> Date: Thu, 29 Oct 2020 22:11:24 +0900
> > >> Subject: [PATCH v2] input: add 2 kind of switch
> > >
> > >Why is this in the body of that patch?
> >
> > I read "how to send your first kernel patch", but still making so many mistakes.
> > I will be cautious with this.
> > 
> > >>
> > >> We need support to various accessories on the device,
> > >> some switch does not exist in switch list.
> > >> So added switch for the following purpose.
> > >>
> > >> SW_COVER_ATTACHED is for the checking the cover
> > >> attached or not on the device. SW_EXT_PEN_ATTACHED is for the
> > >> checking the external pen attached or not on the device
> > >
> > >You didn't answer the previous question as to why the existing values do
> > >not work for you instead of having to create new ones?
> >
> >  I think I should clarify this part the most for this review.
> >  As you know, new added events both has similar existing events,
> >  but it has to operate separately.
> >
> >  First, SW_COVER_ATTACHED is similar with SW_MACHINE_COVER.
> >  We need two events for our cover interaction.
> >  One is to detect if flip cover is open/closed(covers screen or not),
> >  and one is for detecting if cover is attached(detect if device is put into cover).
> >  With the second event, we send event for attachment and start authentication
> >  distinguishing if it was Samsung made cover.
> >
> >  Second, SW_EXT_PEN_ATTACHED detects if pen is attached externally on tablet models.
> >  It is different with SW_PEN_INSERTED since this is detecting pens like our NOTE series.
> >  SW_EXT_PEN_ATTACHED has an unique role to set wacom tuning table differently
> >  while pen is attached/detached.

> All of that needs to go in the changelog text for the individual patches
> when you submit them.

> But as Dmitry pointed out, it doesn't look like either of these drivers
> are needed at all, just use the gpio-keys driver instead.

> thanks,

> greg k-h
 
Can you accept V1 patch? or need to add a change of device tree?
Please let me know what do I do now. 

\
 
 \ /
  Last update: 2020-10-30 12:29    [W:0.357 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site