lkml.org 
[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 2/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P
    Hi Doug,

    On Sat, Oct 24, 2020 at 1:23 AM Douglas Anderson <dianders@chromium.org> wrote:
    >
    > This adds new bindings for the Goodix GT7375P touchscreen. While this
    > touchscreen works with generic "i2c-over-hid", the current advice is
    > to give it its own compatible string. The cleanest way to do this is
    > to give it its own bindings.
    >
    > Among other things, this has the advantage that we can list the two
    > possible i2c addresses for this device, which gives extra checking.
    >
    > Signed-off-by: Douglas Anderson <dianders@chromium.org>
    > ---
    >
    > Changes in v2:
    > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2.
    >
    > .../bindings/input/goodix,gt7375p.yaml | 64 +++++++++++++++++++
    > 1 file changed, 64 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
    > new file mode 100644
    > index 000000000000..b5008f89e26c
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
    > @@ -0,0 +1,64 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Goodix GT7375P touchscreen
    > +
    > +maintainers:
    > + - Benjamin Tissoires <benjamin.tissoires@redhat.com>

    Given my answer in patch 1, I am not very happy being added as a
    maintainer here.

    Cheers,
    Benjamin


    > + - Douglas Anderson <dianders@chromium.org>
    > +
    > +description:
    > + Supports the Goodix GT7375P touchscreen.
    > +
    > +properties:
    > + compatible:
    > + items:
    > + - const: goodix,gt7375p
    > +
    > + reg:
    > + enum:
    > + - 0x5d
    > + - 0x14
    > +
    > + interrupts:
    > + maxItems: 1
    > +
    > + reset-gpios:
    > + true
    > +
    > + vdd-supply:
    > + description: The 3.3V supply to the touchscreen.
    > +
    > +required:
    > + - compatible
    > + - reg
    > + - interrupts
    > + - reset-gpios
    > + - vdd-supply
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/clock/qcom,rpmh.h>
    > + #include <dt-bindings/gpio/gpio.h>
    > + #include <dt-bindings/interrupt-controller/irq.h>
    > +
    > + i2c {
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > + ap_ts: touchscreen@5d {
    > + compatible = "hid-over-i2c";
    > + reg = <0x5d>;
    > +
    > + interrupt-parent = <&tlmm>;
    > + interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
    > +
    > + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
    > + vdd-supply = <&pp3300_ts>;
    > + };
    > + };
    > --
    > 2.29.0.rc1.297.gfa9743e501-goog
    >

    \
     
     \ /
      Last update: 2020-10-30 11:53    [W:2.527 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site