lkml.org 
[lkml]   [2020]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE
Date
Luo Jiaxing <luojiaxing@huawei.com> writes:

> Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
^^^^^^^^^^ ^^^^^
introduce macro

> Read-Write file, So we apply it at dwc3 debugfs to reduce some duplicate
^^ ^^^^^^^^^
so duplicated

> code.

to be fair, your commit is doing more than what it claims. Maybe update
commit log with a "while at that, also use DEFINE_SHOW_ATTRIBUTE() where
possible".

> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>

other than that, this looks okay. Since it depends on the definition of
DEFINE_SHOW_STORE_ATTRIBUTE:

Acked-by: Felipe Balbi <balbi@kernel.org>

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-10-30 10:00    [W:0.255 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site