Messages in this thread | | | Date | Fri, 30 Oct 2020 09:41:12 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v8 -tip 08/26] sched/fair: Snapshot the min_vruntime of CPUs on force idle |
| |
On Thu, Oct 29, 2020 at 10:42:29PM -0400, Joel Fernandes wrote:
> Forgot to ask, do you also need to do the task_vruntime_update() for > the unconstrained pick?
Humm.. interesting case.
Yes, however... since in that case the picks aren't synchronized it's a wee bit dodgy. I'll throw it on the pile together with SMT4.
Also, I'm still hoping you can make this form work:
https://lkml.kernel.org/r/20201026093131.GF2628@hirez.programming.kicks-ass.net
(note that the put_prev_task() needs an additional rq argument)
That's both simpler code and faster.
| |