lkml.org 
[lkml]   [2020]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v10 1/4] bitops: Introduce the for_each_set_clump macro
    On Sat, Oct 3, 2020 at 3:56 PM William Breathitt Gray
    <vilhelm.gray@gmail.com> wrote:
    > On Sat, Oct 03, 2020 at 03:45:04PM +0300, Andy Shevchenko wrote:
    > > On Sat, Oct 3, 2020 at 2:37 PM Syed Nayyar Waris <syednwaris@gmail.com> wrote:
    > > > On Sat, Oct 3, 2020 at 2:14 PM Andy Shevchenko
    > > > <andy.shevchenko@gmail.com> wrote:
    > > > > On Sat, Oct 3, 2020 at 2:51 AM Syed Nayyar Waris <syednwaris@gmail.com> wrote:

    ...

    > > > > > + map[index] &= ~BITMAP_FIRST_WORD_MASK(start);
    > > > > > + map[index] |= value << offset;
    > >
    > > Side note: I would prefer + 0 here and there, but it's up to you.
    > >
    > > > > > + map[index + 1] &= ~BITMAP_LAST_WORD_MASK(start + nbits);
    > > > > > + map[index + 1] |= (value >> space);
    > >
    > > By the way, what about this in the case of start=0, nbits > 64?
    > > space == 64 -> UB.
    > >
    > > (And btw parentheses are redundant here)
    >
    > I think this is the same situation as before: we should document that
    > nbits must be between 1 and BITS_PER_LONG.

    At least documented, yes.

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2020-10-03 15:04    [W:4.662 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site