Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 29 Oct 2020 09:11:09 -0700 | Subject | Re: [PATCH 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop |
| |
Hi,
On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd <swboyd@chromium.org> wrote: > > There's no reason we need to wait here to poll a register over i2c. The > i2c bus is inherently slow and delays are practically part of the > protocol because we have to wait for the device to respond to any > request for a register. Let's rely on the sleeping of the i2c controller > instead of adding any sort of delay here in the bridge driver. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Jonas Karlman <jonas@kwiboo.se> > Cc: Jernej Skrabec <jernej.skrabec@siol.net> > Cc: Sean Paul <seanpaul@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Since we already did some early reviews off-list, it's not a surprise that I have no comments. ;-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |