Messages in this thread Patch in this message | | | From | Coiby Xu <> | Date | Thu, 29 Oct 2020 22:43:32 +0800 | Subject | Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP |
| |
HI Jonathan,
On Thu, Oct 29, 2020 at 02:40:07PM +0000, Jonathan Cameron wrote: >On Thu, 29 Oct 2020 15:48:56 +0800 >Coiby Xu <coiby.xu@gmail.com> wrote: > >> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. >> >> Signed-off-by: Coiby Xu <coiby.xu@gmail.com> >Hi Coiby, > >Please put a cover letter on your next series explaining the context. >In this particular case some of the replies you have gotten are >general at it is a lot easier to find these sorts of things via >replying to the cover letter. >
I will do it in v2. Thank you for the suggestion!
>Jonathan > >> --- >> drivers/iio/accel/da311.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/iio/accel/da311.c b/drivers/iio/accel/da311.c >> index 3b3df620ba27..55d4891556ca 100644 >> --- a/drivers/iio/accel/da311.c >> +++ b/drivers/iio/accel/da311.c >> @@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client) >> return da311_enable(client, false); >> } >> >> -#ifdef CONFIG_PM_SLEEP >> static int da311_suspend(struct device *dev) >> { >> return da311_enable(to_i2c_client(dev), false); >> @@ -273,7 +272,6 @@ static int da311_resume(struct device *dev) >> { >> return da311_enable(to_i2c_client(dev), true); >> } >> -#endif >> >> static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume); >> >
-- Best regards, Coiby
| |