Messages in this thread | | | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast | Date | Thu, 29 Oct 2020 11:06:47 +0000 |
| |
On Wed, Oct 28, 2020 at 07:37:09PM -0700, Florian Fainelli wrote: > If the MDB object is programmed with SWITCHDEV_OBJ_ID_HOST_MDB then you > would need this gfp_t to be GFP_ATOMIC per > net/bridge/br_mdb.c::__br_mdb_notify, if this is a regular > SWITCHDEV_OBJ_ID_MDB then GFP_KERNEL appears to be fine.
Good point, I think I would need to do something more radical anyway, as programming anything into the MAC table calls: ocelot_mact_learn -> ocelot_mact_wait_for_completion -> readx_poll_timeout I'm thinking to move all of this into a workqueue.
| |