lkml.org 
[lkml]   [2020]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND PATCH] soc: ti: ti_sci_pm_domains: check for proper args count in xlate
    Date
    K2G devices still only use single parameter for power-domains property,
    so check for this properly in the driver. Without this, every peripheral
    fails to probe resulting in boot failure.

    Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one")
    Reported-by: Nishanth Menon <nm@ti.com>
    Signed-off-by: Tero Kristo <t-kristo@ti.com>
    Acked-by: Nishanth Menon <nm@ti.com>
    Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
    ---
    drivers/soc/ti/ti_sci_pm_domains.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c
    index af2126d2b2ff..8afb3f45d263 100644
    --- a/drivers/soc/ti/ti_sci_pm_domains.c
    +++ b/drivers/soc/ti/ti_sci_pm_domains.c
    @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate(
    struct genpd_onecell_data *genpd_data = data;
    unsigned int idx = genpdspec->args[0];

    - if (genpdspec->args_count < 2)
    + if (genpdspec->args_count != 1 && genpdspec->args_count != 2)
    return ERR_PTR(-EINVAL);

    if (idx >= genpd_data->num_domains) {
    --
    2.17.1
    --
    Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

    \
     
     \ /
      Last update: 2020-10-29 10:35    [W:4.215 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site