Messages in this thread | | | From | Xie He <> | Date | Thu, 29 Oct 2020 16:10:53 -0700 | Subject | Re: [PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames |
| |
On Thu, Oct 29, 2020 at 10:00 AM Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote: > > This does change rx_dropped count on errors. Not sure how important > that is. But perhaps good to call out in the commit explicitly if it's > intentional.
Yes, this is intentional, because I think we need to count it as a "drop" whenever we drop an skb. I'll note this explicitly in the commit message in the next versions of the patch. Thanks!
| |