lkml.org 
[lkml]   [2020]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Input: goodix - add option to disable firmware loading
Hi Andrej,

On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote:
> Firmware file loadind for GT911 controller takes too much time (~60s).
> There is no check that configuration is the same which is already present.
> This happens always during boot, which makes touchscreen unusable.
>
> Add there an option to prevent firmware file loading, but keep it enabled
> by default.

I thought that Goodix was losing firmware loading at poweroff. Is this
not the case with this model?

Adding Hans as he was working with this driver/code.

>
> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> ---
> drivers/input/touchscreen/goodix.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 02c75ea385e08..44336ecd2acdf 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -941,7 +941,9 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts)
> default:
> if (ts->gpiod_int && ts->gpiod_rst) {
> ts->reset_controller_at_probe = true;
> - ts->load_cfg_from_disk = true;
> + /* Prevent cfg loading for each start */
> + ts->load_cfg_from_disk = !device_property_read_bool(dev,
> + "touchscreen-do-not-load-fw");
> ts->irq_pin_access_method = IRQ_PIN_ACCESS_GPIO;
> }
> }
> --
> 2.20.1
>

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2020-10-29 21:36    [W:0.362 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site