lkml.org 
[lkml]   [2020]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] leds: various: add missing put_device() call in netxbig_leds_get_of_pdata()
    Hi!

    > if of_find_device_by_node() succeed, netxbig_leds_get_of_pdata() doesn't
    > have a corresponding put_device(). Thus add jump target to fix the
    > exception handling for this function implementation.
    >
    > Fixes: 2976b1798909 ("leds: netxbig: add device tree binding")
    > Signed-off-by: Yu Kuai <yukuai3@huawei.com>

    Thanks, applied.

    But it seems to me similar handling is needed in "success" paths, no?

    Best regards,
    Pavel
    --
    http://www.livejournal.com/~pavelmachek
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-10-29 18:50    [W:5.801 / U:1.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site