lkml.org 
[lkml]   [2020]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/atm: use list_is_singular() in br2684_setfilt()
On Tue, 27 Oct 2020 00:57:00 +0800 Hui Su wrote:
> list_is_singular() can tell whether a list has just one entry.
> So we use list_is_singular() here.
>
> Signed-off-by: Hui Su <sh_def@163.com>
> ---
> net/atm/br2684.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/atm/br2684.c b/net/atm/br2684.c
> index 3e17a5ecaa94..398f7e086cf4 100644
> --- a/net/atm/br2684.c
> +++ b/net/atm/br2684.c
> @@ -372,8 +372,7 @@ static int br2684_setfilt(struct atm_vcc *atmvcc, void __user * arg)
> struct br2684_dev *brdev;
> read_lock(&devs_lock);
> brdev = BRPRIV(br2684_find_dev(&fs.ifspec));
> - if (brdev == NULL || list_empty(&brdev->brvccs) ||
> - brdev->brvccs.next != brdev->brvccs.prev) /* >1 VCC */
> + if (brdev == NULL || !list_is_singular(&brdev->brvccs)) /* >1 VCC */

You can drop the /* >1 VCC */ comment now, the code is clear enough

> brvcc = NULL;
> else
> brvcc = list_entry_brvcc(brdev->brvccs.next);

\
 
 \ /
  Last update: 2020-10-29 01:58    [W:0.032 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site