Messages in this thread | | | Subject | Re: [PATCH 0/8] Style and small fixes for core-scheduling | From | John Wyatt <> | Date | Wed, 28 Oct 2020 11:58:34 -0700 |
| |
Hi Phil,
> Hi John, > > Welcome!
Thank you!
> > > Please feel free to advise on any corrections or improvements that > > can be > > made. > > Thanks for these. I wonder, though, if it would not make more sense > to post these changes as comments on the original as-yet-unmerged > patches that you are fixing up?
Patch 23/26 has a lot of spaces to tabs issues that are isolated to one file (and one patch if I read it correctly). It would definitely make sense for those to be a comment. Especially with patch 23 being a later patch in the patch series. Most of those issues are not fixed by this patch series I submitted.
For the rest, I am willing to do resubmit as comments if that would be easier for the submitter.
Please let me know if that is how I should resubmit them.
Being a patch set does makes them easier to verify. Some warnings against the individual patches, like braces surrounding a one line in a if block, disappear with later patches as the code is added. For clarity for the mailing list, I used the jfern tree with the 'coresched-v8-posted-to-list'.
https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/tag/?h=coresched-v8-posted-to-list
Thank you for your feedback.
-- Sincerely, John Wyatt
| |